Add HasCallStack to internalError#2608
Merged
paf31 merged 4 commits intopurescript:masterfrom Jan 30, 2017
Merged
Conversation
alexbiehl
force-pushed
the
internal-error
branch
from
978408a to
40417a8
Compare
Contributor
|
The line endings on the diff look a bit funny - could you check to see if this has a mixture of Linux and windows style line endings? |
Contributor
|
This fixes #2538. I generally like to avoid CPP but this seems like a good reason to use it. 👍 once line endings are sorted. |
alexbiehl
force-pushed
the
internal-error
branch
from
40417a8 to
a00ebb8
Compare
Contributor
Author
|
Updated the patch. This even works for GHC-7.x. They won't print a callstack though. |
paf31
approved these changes
Jan 29, 2017
Contributor
|
Looks good, thanks! Please can you update |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might be useful in case of a crash.