Skip to content

Add git tag time to psc-publish JSON#2544

Merged
hdgarrood merged 1 commit intomasterfrom
include-tag-date
Jan 6, 2017
Merged

Add git tag time to psc-publish JSON#2544
hdgarrood merged 1 commit intomasterfrom
include-tag-date

Conversation

@hdgarrood
Copy link
Copy Markdown
Contributor

@hdgarrood hdgarrood commented Jan 6, 2017

This is done in a backwards-compatible way by making the time in the
Package type a Maybe UTCTime. Later we can change this to just a
UTCTime.

Prerequisite for addressing purescript/pursuit#216

This is done in a backwards-compatible way by making the time in the
Package time a Maybe UTCTime. Later we can change this to just a
UTCTime.

Prerequisite for addressing purescript/pursuit#216
Copy link
Copy Markdown
Contributor

@paf31 paf31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thanks!

@hdgarrood hdgarrood merged commit 307b71d into master Jan 6, 2017
@hdgarrood hdgarrood deleted the include-tag-date branch January 6, 2017 22:25
@hdgarrood
Copy link
Copy Markdown
Contributor Author

Oops, CI is failing because I merged this a bit hastily. Hopefully it will pass on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants