[psc-ide] use unicode forall and arrows in completions#2532
Merged
kritzcreek merged 1 commit intopurescript:masterfrom Jan 6, 2017
Merged
[psc-ide] use unicode forall and arrows in completions#2532kritzcreek merged 1 commit intopurescript:masterfrom
kritzcreek merged 1 commit intopurescript:masterfrom
Conversation
Contributor
|
Replacing strings seems a bit sketchy. Why not pass options to |
Member
Author
|
You're right, done. |
Member
Author
|
Hmm the windows failure needs a bit of encoding massaging... |
Contributor
|
Thanks! Looks good once the encoding issue is sorted. |
kritzcreek
force-pushed
the
psc-ide-pretty-unicode-types
branch
3 times, most recently
from
26161b4 to
37674de
Compare
Member
Author
|
The tests pass again... I had to take explicit control over the psc-ide process for the integration tests. If this looks fine I'll squash and merge. |
paf31
approved these changes
Jan 6, 2017
* removes the conversion module. now that the compiler types have been switched to Text the conversion module is no longer needed * adds parameterized versions of prettyPrintType * fixes unicode issues in the test suite on windows
kritzcreek
force-pushed
the
psc-ide-pretty-unicode-types
branch
from
37674de to
ffaa9d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the unicode syntax for the reported types looks nice and has the added benefit of reducing the popup/message size.
Doing a simple string replacement is not the most robust solution, but I'm fairly certain it's good enough for our purposes. If a typevariable ending in
forallgets altered it's easy enough to figure out what has happened for the user.