Update orphan instance check to use covering sets#2522
Merged
paf31 merged 1 commit intopurescript:masterfrom Jan 2, 2017
LiamGoodacre:update/orphan-detection
Merged
Update orphan instance check to use covering sets#2522paf31 merged 1 commit intopurescript:masterfrom LiamGoodacre:update/orphan-detection
paf31 merged 1 commit intopurescript:masterfrom
LiamGoodacre:update/orphan-detection
Conversation
paf31
suggested changes
Jan 1, 2017
| Just ms -> S.fromList (toList ms) | ||
| Nothing -> internalError "Unknown type index in checkOrphanInstance" | ||
|
|
||
| nonOrphanModules :: S.Set ModuleName |
Contributor
There was a problem hiding this comment.
Could you please add a short comment explaining why we take the intersection here?
Contributor
|
I'd like to merge this in to 0.10.4, so I'm going to merge this and tag. We can add the comment later. |
paf31
approved these changes
Jan 2, 2017
Member
Author
|
(I already added a comment; perhaps I should have made a new commit instead of amending, so it was more obvious there was a change.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #2394
Let me know if you think of any more tests, want me to comment more with explanations, etc.
I think the error message for
OrphanInstancealso wants updating - I'll have a look at that shortly.