Conversation
|
I've added basic support for records (that is, data types with a single argument which is a record - we can expand this later if necessary). Tests should start passing once purescript-deprecated/purescript-generics-rep#2 is merged. |
|
Tests are now passing, apart from the one which was failing already anyway. |
| "purescript-partial": "1.1.2", | ||
| "purescript-newtype": "0.1.0" | ||
| "purescript-newtype": "0.1.0", | ||
| "purescript-generics-rep": "2.0.0" |
There was a problem hiding this comment.
Should we update the rest of the versions of these while we're at it? Will probably need to tweak some tests, but may as well get it done, since the dependencies conflict with this (I think?).
There was a problem hiding this comment.
I think we definitely should soon, but I'd like to leave it for a separate PR after this one. I think there might be a lot more changes needed than we suspect 😄
There was a problem hiding this comment.
Okidoke. How does these even work now without resolutions specified?!
There was a problem hiding this comment.
I think generics-rep-2.0.0 used the pre-0.10 libraries.
|
👍 then, but I guess we should bump things so we can test against the latest |
|
Yes, agreed. I'll write up an issue. |
2 participants
Fixes #2348
This needs a little more work, since it doesn't handle record types yet, but everything else seems to be working.
Here is a short demo.