[psc-ide] Return qualifier from explicit/hiding imports#2317
Merged
paf31 merged 1 commit intopurescript:masterfrom Sep 23, 2016
Merged
[psc-ide] Return qualifier from explicit/hiding imports#2317paf31 merged 1 commit intopurescript:masterfrom
paf31 merged 1 commit intopurescript:masterfrom
Conversation
kritzcreek
requested changes
Sep 20, 2016
Member
kritzcreek
left a comment
kritzcreek
left a comment
There was a problem hiding this comment.
Just minor syntax things, otherwise looks good!
src/Language/PureScript/Ide/Types.hs
Outdated
| object [ "module" .= mn | ||
| toJSON (ModuleImport mn (P.Explicit refs) qualifier) = | ||
| object $ [ "module" .= mn | ||
| , "importType" .= ("explicit" :: Text) |
Member
There was a problem hiding this comment.
Keep the alignment of [ and , please
src/Language/PureScript/Ide/Types.hs
Outdated
| ] | ||
| toJSON (ModuleImport mn (P.Hiding refs) _) = | ||
| object [ "module" .= mn | ||
| ] ++ fmap (\x -> "qualifier" .= x) (maybeToList qualifier) |
Member
There was a problem hiding this comment.
The Protolude is imported here so just map is actually the Functor version.
Contributor
Author
There was a problem hiding this comment.
Hmm, this was ambiguous due to the non-qualified import of Data.Map.Lazy. Had no idea Haskell had both import qualified ... as ... and import ... as ... forms...
Member
There was a problem hiding this comment.
Haskell's namespacing is way too complex...
src/Language/PureScript/Ide/Types.hs
Outdated
| , "importType" .= ("hiding" :: Text) | ||
| , "identifiers" .= (identifierFromDeclarationRef <$> refs) | ||
| ] | ||
| ] ++ fmap (\x -> "qualifier" .= x) (maybeToList qualifier) |
Member
|
Oh yeah and it would be nice if you could add the two fields to |
nwolverson
force-pushed
the
psc-ide-listimports-qualified
branch
from
4cf9233 to
e5cae6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.