Merged
Conversation
Member
|
Won't this cause any connection failure to crash the |
Contributor
Author
|
Ah, true. One want to catch all exceptions... I'll revert that functionality |
phadej
force-pushed
the
http-client-0.5
branch
from
2598155 to
e0527fb
Compare
Contributor
Author
|
reverted |
Contributor
Author
|
I have no idea why osx tests failed, could they be restarted? |
Member
|
Yeah that's not a genuine failure. There's something flaky compiling psc-ide's test assets... |
Member
|
I hope the tests will work reliably again after #2286. |
| P.fold (<>) "" identity (responseBody resp) | ||
|
|
||
| let qClean = T.dropWhileEnd (== '.') q | ||
| req' <- parseRequest "http://pursuit.purescript.org/search" |
Contributor
There was a problem hiding this comment.
Can this be changed to https now?
Contributor
Author
There was a problem hiding this comment.
I'll leave this for someone else to change.
Contributor
|
LGTM, other than my https comment. @kritzcreek good to merge then? |
Member
|
Looks good from my side 👍 |
Contributor
|
Thanks @phadej! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.