Skip to content

gitignore .psc-ide-port globally#2261

Merged
paf31 merged 1 commit intopurescript:masterfrom
rvion:gitignore-core-tests-psc-ide-port
Aug 14, 2016
Merged

gitignore .psc-ide-port globally#2261
paf31 merged 1 commit intopurescript:masterfrom
rvion:gitignore-core-tests-psc-ide-port

Conversation

@rvion
Copy link
Copy Markdown
Contributor

@rvion rvion commented Aug 5, 2016

No description provided.

@hdgarrood
Copy link
Copy Markdown
Contributor

Can you explain what this file does and what tools use it please?

@kritzcreek
Copy link
Copy Markdown
Member

The atom plugin and pscid use it keep book about a started psc-ide-server and its port.

@hdgarrood
Copy link
Copy Markdown
Contributor

Ah, cool, thanks.

@no-longer-on-githu-b
Copy link
Copy Markdown
Contributor

no-longer-on-githu-b commented Aug 5, 2016

I think this should not be in the repository's gitignore file, as it is specific to a tool some people use, instead of something generated by the build tools. You don't put *.swp in every gitignore file either.

Rather, it should be in the global ignores file of the user, which can be set with git config --global core.excludesfile.

@texastoland
Copy link
Copy Markdown

texastoland commented Aug 5, 2016

The difference is every IDE (VS Code too) ostensibly uses that file (see purescript-contrib/pulp#223) versus being editor specific (Eclipse in the case of your example I think). Depending on global configuration is typically a bad idea.

@rvion
Copy link
Copy Markdown
Contributor Author

rvion commented Aug 5, 2016

@rightfold Since most tools will use psc-ide-server, I still think it makes sense for the file to be included in some gitignore. (either this one or the global root .gitignore). this being said, I have no strong opinion about that and understand your concern

@rvion
Copy link
Copy Markdown
Contributor Author

rvion commented Aug 5, 2016

from my experience, I like to include sensible defaults in gitignores even when they're tool related (eg. https://github.com/github/gitignore/blob/master/Haskell.gitignore)

@paluh
Copy link
Copy Markdown

paluh commented Aug 5, 2016

But there is also local file: .git/info/exclude which everyone can use, to ignore ide/editor/debugger specific files.

@rvion
Copy link
Copy Markdown
Contributor Author

rvion commented Aug 5, 2016

@paluh I mean, even when they are tool-specific-to-your-language-that-mostly-everyone-will-use related

as @texastoland said

The difference is every IDE (VS Code too) ostensibly uses that file (see purescript-contrib/pulp#223) versus being editor specific (Eclipse in the case of your example I think). Depending on global configuration is typically a bad idea.

Feel free to dismiss this PR, I won't commit any .psc-ide-port file anyway, and debating about this is not very productive ^^


FWIW: even purescript global .gitignore contains things like

*.lksh*
.virthualenv
.stack-work/

@paluh
Copy link
Copy Markdown

paluh commented Aug 5, 2016

@rvion Ok, maybe it's just my preference, to put more specific ignores outside project's .gitignore and maybe this puritanism is not really practical ;-) I've just wanted to point out that there is local per repository place for them. Nothing more ;-)

@rvion rvion force-pushed the gitignore-core-tests-psc-ide-port branch from fabb210 to daf7829 Compare August 6, 2016 08:03
@rvion rvion changed the title gitignore core-tests/.psc-ide-port gitignore .psc-ide-port globally Aug 6, 2016
@paf31 paf31 merged commit dcf2c58 into purescript:master Aug 14, 2016
@paf31
Copy link
Copy Markdown
Contributor

paf31 commented Aug 14, 2016

I agree that it probably is a better solution to put this in some local config, but I don't see any harm in merging this either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants