gitignore .psc-ide-port globally#2261
Conversation
|
Can you explain what this file does and what tools use it please? |
|
The atom plugin and pscid use it keep book about a started psc-ide-server and its port. |
|
Ah, cool, thanks. |
|
I think this should not be in the repository's gitignore file, as it is specific to a tool some people use, instead of something generated by the build tools. You don't put Rather, it should be in the global ignores file of the user, which can be set with |
|
The difference is every IDE (VS Code too) ostensibly uses that file (see purescript-contrib/pulp#223) versus being editor specific (Eclipse in the case of your example I think). Depending on global configuration is typically a bad idea. |
|
@rightfold Since most tools will use psc-ide-server, I still think it makes sense for the file to be included in some gitignore. (either this one or the global root .gitignore). this being said, I have no strong opinion about that and understand your concern |
|
from my experience, I like to include sensible defaults in gitignores even when they're tool related (eg. https://github.com/github/gitignore/blob/master/Haskell.gitignore) |
|
But there is also local file: .git/info/exclude which everyone can use, to ignore ide/editor/debugger specific files. |
|
@paluh I mean, even when they are tool-specific-to-your-language-that-mostly-everyone-will-use related as @texastoland said
Feel free to dismiss this PR, I won't commit any .psc-ide-port file anyway, and debating about this is not very productive ^^ FWIW: even purescript global .gitignore contains things like |
|
@rvion Ok, maybe it's just my preference, to put more specific ignores outside project's .gitignore and maybe this puritanism is not really practical ;-) I've just wanted to point out that there is local per repository place for them. Nothing more ;-) |
fabb210 to
daf7829
Compare
|
I agree that it probably is a better solution to put this in some local config, but I don't see any harm in merging this either. |
No description provided.