Update Data.Function constant for prelude 1.0#2213
Merged
paf31 merged 2 commits intopurescript:masterfrom Jul 9, 2016
Merged
Conversation
Member
|
I think there needs to be a bit more updated than this - we need both |
This fixes the compiler not inlining mkFnN, since `Data.Function` has moved to `Data.Function.Uncurried`
felixSchl
force-pushed
the
fix/data-function-constant
branch
from
10e451a to
846ca65
Compare
Contributor
Author
|
@garyb you're right. I gave it another go if you don't mind checking it. I had to update the inlining code to inline |
Member
|
Looks good to me! 👍 Can you add yourself to the |
Contributor
Author
|
Sure thing, done :) |
Contributor
|
Thanks! |
archaeron
pushed a commit
to archaeron/purescript
that referenced
this pull request
Apr 6, 2017
* Update mkFnN inlining for prelude 1.0 This fixes the compiler not inlining mkFnN, since `Data.Function` has moved to `Data.Function.Uncurried` * Update CONTRIBUTORS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the compiler not inlining mkFn, since
Data.Functionhasmoved to
Data.Function.Uncurried