Conversation
|
I opened the last PR from the GitHub client, either forgot to switch the branch or something odd happened 😄 |
| (guard (validModuleName uName) >> Qualifier uName <$ P.char '.') <|> pure (UName uName) | ||
| , parseUName >>= \uName -> | ||
| (guard (validModuleName uName) >> Qualifier uName <$ P.char '.') | ||
| <|> (guard (validUName uName) >> pure (UName uName)) |
There was a problem hiding this comment.
Does it make sense to move these checks into mname, uname, etc.?
There was a problem hiding this comment.
That sounds good to me, I certainly found this a bit strange. Shall I do that then?
There was a problem hiding this comment.
Actually, can we? The P.char '.' thing in there for Qualifier probably obstructs that. Should work for uname / tyname though.
|
I need to update the parsing of |
|
|
| uname' s = token go P.<?> show s | ||
| where | ||
| go (UName s') | s == s' = Just () | ||
| go _ = Nothing |
There was a problem hiding this comment.
Deleted this as it was unused, and I wasn't sure what the right implementation would be anymore: should the validUName predicate apply? etc.
There was a problem hiding this comment.
If it's unused, just get rid, I think.
|
🚢 thanks! |
|
Looks like the nightly build is broken now? Not by this I imagine, there's some message about the compiler. |
|
Yes, the Mac build has been broken for a few days. I've been ignoring it, but maybe we should turn that build off. |
2 participants
Resolves #1569