Merged
Conversation
Contributor
|
Will this throw an error unless you add in an |
Contributor
Author
|
It does, yes. I figured that was probably the best default behavior, since you can always use |
Contributor
Author
|
@hdgarrood So what do you think then? |
Contributor
|
My gut says we should just let people evaluate partial expressions without requiring unsafePartial, but I think this is fine for now; we can try it and see what happens. It's not a big deal. |
Contributor
Author
|
Alright, sounds good. We can create an issue to track it, but I'll merge this for now, so that we can get a release out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed
Partialfunctions would run incorrectly in PSCi since we didn't typecheckmain. Now that we generalize constraints, we need to add a signature.