Conversation
Member
|
👍 |
| do name <- lname | ||
| b <- P.option (VarBinder (Ident name)) rest | ||
| return (name, b) | ||
| <|> (,) <$> stringLiteral <*> rest |
Contributor
Author
There was a problem hiding this comment.
This is the same as before. I thought it could be changed, but I changed it back.
Member
There was a problem hiding this comment.
What's actually happening here in the first place? 😄 I don't quite understand what the stringLiteral is doing here.
Contributor
Author
There was a problem hiding this comment.
You can have { foo: bar } or { foo } or { "!!!": baz }, but not { "!!!" }, since that wouldn't be a valid Ident.
Member
There was a problem hiding this comment.
Ohh, right, I got confused... I'm not sure what I was thinking, but I didn't notice that parseIdentifierAndBinder is only for record pairs.
archaeron
pushed a commit
to archaeron/purescript
that referenced
this pull request
Apr 6, 2017
…#2152) * Fix purescript#2149, remove support for = in ObjectBinder * Extended matches must specify a binder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.