Add tests for warnings & fix some warnings#2137
Merged
garyb merged 1 commit intopurescript:0.9from May 20, 2016
Merged
Conversation
Member
Author
|
Fixed the |
| @@ -0,0 +1,5 @@ | |||
| -- @shouldWarnWith ShadowedTypeVar | |||
Contributor
There was a problem hiding this comment.
Is this just in a separate directory so that it doesn't break the build?
Member
Author
There was a problem hiding this comment.
Yeah, this is something I discovered that I figure should warn, but we currently don't catch. I made the warning detection like the errors: it expect an exact set of warnings, so yeah, it would break the tests currently.
Perhaps I should just open an issue instead and delete this.
Contributor
There was a problem hiding this comment.
Opening an issue instead sounds sensible to me, yeah.
Contributor
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't a comprehensive test suite for the warnings, but I think it's the majority of them. The main one that I know for sure needs covering is the
ShadowedNamestuff.I removed the
RedundantEmptyHidingImportcheck, as it wasn't working, and you'd have to work really hard for that case to arise now anyway, thanks to the unused import warnings. The only way it can happen is if you import a module,hidingeverything, and are re-exporting that module from the current module.The fixes I speak of are things that I inadvertently broke during #2090 - had an
unless'function that was actuallywhen', ran the import linter on the wrong version of a module, etc.