👍 agreed, seems like an improvement to me even if we don't consider performance.

I think it's #2124 that this (hopefully) fixes, incidentally.

Oops, right you are!

Coverage decreased (-0.01%) to 55.89% when pulling b7a6f2b on name-map into 7f29fad on 0.9.

Looks good! How does the profiler output look now?

Note (not sure if you're aware or not, but I'll record it here anyway) that Stack will make a profiling build with

stack build --executable-profiling --library-profiling --ghc-options="-fprof-auto -rtsopts"

(taken from here)

If you run psc with +RTS -p, you'll get a profiling report, and with -hc will give a heap profile.

Creating a separate Stack working directory with --work-dir can also be useful, since you'll end up doing a lot of rebuilding with and without profiling options otherwise.

I haven't got anything significant I can try it on yet, since this is the 0.9 branch.

Ah right, of course. Even building something like purescript-strings should give you a reasonable profile to look at though.

The other hotspot in the profile was a space leak in the lexer, which the lexLazy variant should fix. I should remember to come back to that.