Conversation
Contributor
|
👍 lgtm |
| -> [(k, String)] | ||
| -> m [(k, Module)] | ||
| parseModulesFromFiles toFilePath input = | ||
| flip parU id $ map wrapError $ inParallel $ flip map input $ \(k, content) -> do |
Contributor
There was a problem hiding this comment.
Non-blocking: this can be simplified to flip parU wrapError . inParallel . flip map input.
Contributor
|
👍 Thanks! I started this last night but stopped when I realized I had to change the examples 😄 |
garyb
force-pushed
the
single-module-files
branch
from
0e23de7 to
ef14768
Compare
Contributor
|
👍 Looks good to merge. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@paf31 I have a bit of time after all 😉
This is pretty straightforward, mostly updates to the docs tests to make them parse.