Conversation
…dOptimize # Conflicts: # src/Language/PureScript/Bundle.hs # src/Language/PureScript/BundleOpt.hs # src/Language/PureScript/BundleTypes.hs
|
Sorry for the confusion, but could you please base this on the aside: This branching scheme has turned out to be a little confusing; perhaps if we want to do something like this in the future, we should have |
|
|
||
| -- * Call replacement | ||
|
|
||
| -- | replace satured calls to calls to uncurried functions |
|
Also, can we have some tests, please? Perhaps write some programs, compile them both with and without the uncurry optimization, and verify that they behave in the same way? |
|
|
||
| shouldUncurry :: Parser String | ||
| shouldUncurry = strOption $ | ||
| short 'p' |
There was a problem hiding this comment.
psc currently has one option for turning each individual optimization on or off, --no-tco, --no-magic-do, with no short version so perhaps we should follow suit here? --[no-]optimize-uncurry?
|
Thanks for the PR! I'll spend some time reviewing this during the week. |
|
I have submitted a new pull request #2139 which is based on 0.9 as required. I have as well fixed the typo. |
3 participants
See issue Uncurry optimization #479. Here's the read-up: http://symbolian.net/2016/04/07/513