Skip to content

Switch to stack for CI, resolves #1974#2099

Merged
paf31 merged 2 commits intopurescript:0.9from
hdgarrood:stack-travis
May 8, 2016
Merged

Switch to stack for CI, resolves #1974#2099
paf31 merged 2 commits intopurescript:0.9from
hdgarrood:stack-travis

Conversation

@hdgarrood
Copy link
Copy Markdown
Contributor

  • Remove the stack-nightly.yaml, since it always needs updating.
    Instead, we pass --resolver=nightly in one of the build jobs to ensure
    we always have the latest nightly. As an added bonus we no longer have
    to set the STACK_YAML environment variable on Windows, because
    stack.yaml is no longer a symlink.
  • Remove use of cabal-install, which drastically simplifies the CI
    scripts :)
  • Use the 'compiler' key in the build matrix as a hack to ensure each
    build job gets a separate cache.
  • Add OSX tests.
  • Add haddock tests, on a separate build job (for speed).
  • Use separate build jobs for sdist tests (for speed).
  • Fix binary bundle uploading on Travis
  • Add binary bundle uploading for OSX.

Coverage did not work when I was building on Travis with my fork, but I think that was because of an API key environment variable missing, or something like that. So hopefully it should work here.

* Remove the stack-nightly.yaml, since it always needs updating.
  Instead, we pass --resolver=nightly in one of the build jobs to ensure
  we always have the latest nightly. As an added bonus we no longer have
  to set the STACK_YAML environment variable on Windows, because
  stack.yaml is no longer a symlink.
* Remove use of cabal-install, which drastically simplifies the CI
  scripts :)
* Use the 'compiler' key in the build matrix as a hack to ensure each
  build job gets a separate cache.
* Add OSX tests.
* Add haddock tests, on a separate build job (for speed).
* Use separate build jobs for sdist tests (for speed).
* Fix binary bundle uploading on Travis
* Add binary bundle uploading for OSX.
@hdgarrood
Copy link
Copy Markdown
Contributor Author

Resolves #2034.

* No longer need to set STACK_YAML on AppVeyor
* We should not attempt to run 'strip' on Windows executables
* Fix path to bundle creation script
@hdgarrood
Copy link
Copy Markdown
Contributor Author

In case you were wondering, I've canceled the Travis CI build for the second commit. I'm going to restart it when the first one finishes so that it can use the cache.

@paf31
Copy link
Copy Markdown
Contributor

paf31 commented May 8, 2016

Great work, thanks very much!

Just a note: this also seems to remove the core-tests run. I'm not sure if that was even working on 0.9 anyway due to the breaking changes, but it'll be worth trying to reinstate it at some point. We'll have to remember to run it manually before releasing 0.9.

@hdgarrood
Copy link
Copy Markdown
Contributor Author

👍 , opened #2101

@coveralls
Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 4e30241 on hdgarrood:stack-travis into * on purescript:0.9*.

@paf31 paf31 added this to the 0.9.0 milestone May 8, 2016
@coveralls
Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 4e30241 on hdgarrood:stack-travis into * on purescript:0.9*.

@paf31
Copy link
Copy Markdown
Contributor

paf31 commented May 8, 2016

So this is ready to merge?

@hdgarrood
Copy link
Copy Markdown
Contributor Author

I think so.

@paf31 paf31 merged commit 10f76a7 into purescript:0.9 May 8, 2016
@paf31
Copy link
Copy Markdown
Contributor

paf31 commented May 8, 2016

Thanks very much!

@hdgarrood hdgarrood deleted the stack-travis branch May 8, 2016 19:56
archaeron pushed a commit to archaeron/purescript that referenced this pull request Apr 6, 2017
* Switch to stack for CI, resolves purescript#1974

* Remove the stack-nightly.yaml, since it always needs updating.
  Instead, we pass --resolver=nightly in one of the build jobs to ensure
  we always have the latest nightly. As an added bonus we no longer have
  to set the STACK_YAML environment variable on Windows, because
  stack.yaml is no longer a symlink.
* Remove use of cabal-install, which drastically simplifies the CI
  scripts :)
* Use the 'compiler' key in the build matrix as a hack to ensure each
  build job gets a separate cache.
* Add OSX tests.
* Add haddock tests, on a separate build job (for speed).
* Use separate build jobs for sdist tests (for speed).
* Fix binary bundle uploading on Travis
* Add binary bundle uploading for OSX.

* Update appveyor CI

* No longer need to set STACK_YAML on AppVeyor
* We should not attempt to run 'strip' on Windows executables
* Fix path to bundle creation script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants