Skip to content

Update the support modules list in the tests#2081

Merged
garyb merged 1 commit into0.9from
test-support-modules
May 2, 2016
Merged

Update the support modules list in the tests#2081
garyb merged 1 commit into0.9from
test-support-modules

Conversation

@garyb
Copy link
Copy Markdown
Member

@garyb garyb commented May 1, 2016

No description provided.

@garyb garyb added this to the 0.9.0 milestone May 1, 2016
@paf31
Copy link
Copy Markdown
Contributor

paf31 commented May 1, 2016

👍 Thanks!

@paf31
Copy link
Copy Markdown
Contributor

paf31 commented May 1, 2016

Is there something I need to do to get tests running? They all seem to be failing for me.

@garyb
Copy link
Copy Markdown
Member Author

garyb commented May 1, 2016

Hmm, no. That kinda was the point of switching back to bower, that it should "just work"... Travis is managing okay too. Perhaps clear out the stuff you have in support and try again?

@hdgarrood
Copy link
Copy Markdown
Contributor

Should we be sharing this list across both of these modules?

@garyb
Copy link
Copy Markdown
Member Author

garyb commented May 1, 2016

That would make sense... I'll revise it.

Also add comment explaining what the list actually does
@garyb garyb force-pushed the test-support-modules branch from c6ec741 to 06e4332 Compare May 1, 2016 22:52
@garyb
Copy link
Copy Markdown
Member Author

garyb commented May 1, 2016

The list is shared now.

@hdgarrood
Copy link
Copy Markdown
Contributor

👍

@garyb garyb merged commit ac2b456 into 0.9 May 2, 2016
@garyb garyb deleted the test-support-modules branch May 2, 2016 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants