Merged
Conversation
* The current usage of psc-ide involves loading all modules anyway, so we don't worry about loading previously unloaded modules. * Don't attempt to reload deleted files
Contributor
|
👍 LGTM |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we don't worry about loading previously unloaded modules.
This could lead to surprising behaviour when you're managing the loaded modules manually. Since all the editor plugins have switched to just loading all the modules upfront anyway I don't think it's too big of a problem.
This change will cause psc-ide to reload all externs files that get added or changed inside the output folder, thus picking up newly added sourcefiles (through bower or by creating a new module) when they get compiled for the first time.