Marking code with backticks in error messages#2060
Marking code with backticks in error messages#2060soupi wants to merge 2 commits intopurescript:masterfrom soupi:master
Conversation
|
👍 |
|
👍 from me too. |
|
Actually I wonder if we could make it a little more type-safe by having |
|
That way, you only need to call one function, too; |
|
Sort of related, should the following two constructors have purescript/src/Language/PureScript/Errors.hs Lines 128 to 129 in 5aaf615 |
|
What @hdgarrood said (I just didn't have as clear an idea how to fix it) 👍 |
|
Also, I don't know what the right answer is here, but it might be worth considering putting the backticks directly into |
|
Re: the above suggestion - I'm not sure every name shown in errors comes through with an |
|
Ok, then this LGTM. |
|
Could you please reopen this as a PR on the 0.9 branch? |
|
Thanks! |
Implementing the request at #2056, is this what we might want?