Closed
Conversation
Make as-patterns bind less tightly
Contributor
|
Could you please rebase this and your other PR against the 0.9 branch? I'm going to use |
* The current usage of psc-ide involves loading all modules anyway, so we don't worry about loading previously unloaded modules. * Don't attempt to reload deleted files
…provements Always reload Externs
nwolverson
force-pushed
the
type-suggestions
branch
from
e6183eb to
a04c552
Compare
Contributor
Author
|
Rebased on 0.9. As per other PR let me know if you want to open a fresh PR. |
Member
|
@nwolverson I believe we want new PRs on the 0.9 branch - see #2067 |
Contributor
|
Yes, I think you need to open a fresh PR. Thanks! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 new suggestions here for editor support etc.
MissingTypeDeclaration- adding a separate source range in the JSON suggestion field to support this, I think that's likely something that could be used elsewhere. Idea being the replacement range may not coincide with the warning/error rangeTypeWildCard- Main thing here is this needed a source position for the wildcard itself rather than the whole thing. I tried a generalPositionedTypeconstructor as perPositionedValuebut ended up scattering junk all over the typechecker without managing to make it work. I imagine types may want detailed error positions in the future obsoleting some of this, but I can't work out the details. This looks good with psa now.