Remove deprecated class import/export syntax#2025
Closed
LiamGoodacre wants to merge 1 commit intopurescript:masterfrom
LiamGoodacre:update/remove-deprecated-class-syntax
Closed
Remove deprecated class import/export syntax#2025LiamGoodacre wants to merge 1 commit intopurescript:masterfrom LiamGoodacre:update/remove-deprecated-class-syntax
LiamGoodacre wants to merge 1 commit intopurescript:masterfrom
LiamGoodacre:update/remove-deprecated-class-syntax
Conversation
Member
Author
|
The failing tests appear to be using a version of the prelude which doesn't use the updated class import/export syntax. |
Member
|
#1963 should address that. Hopefully we're going to release an 0.8.5 before 0.9 though, so there's a whole bunch of PRs that are waiting for that first. |
Contributor
|
@LiamGoodacre Could you please reopen this as a PR on the 0.9 branch? |
Member
Author
|
Will do! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #2012