Conversation
| -- will be removed. | ||
| -- | ||
| | ParensInBinder Binder | ||
| -- | |
There was a problem hiding this comment.
I haven't really made use of this yet, as the parsing is not correct, but I assume we'll need something like this to enable fixity overriding as with the normal operators?
garyb
force-pushed
the
dctor-operator-aliases
branch
6 times, most recently
from
832585e to
fdf3af2
Compare
|
Ok, I think this is good to review now. Do you know what's going on with the errors Travis keeps giving? Something about aeson? It's been building locally without errors or warnings for me for the last few pushes, yet keeps failing on Travis. |
| renderSimpleErrorMessage (TransitiveDctorExportError x ctor) = | ||
| paras [ line $ "An export for " ++ prettyPrintExport x ++ " requires the following data constructor to also be exported: " | ||
| , indent $ line $ runProperName ctor | ||
| ] |
There was a problem hiding this comment.
I did this with a new error message as we can't really generate a good error message for the export using a DeclarationRef and the TransitiveDctorExportError, as it would mean doing quite a bit of work to figure out if the type for the data constructor is already exported, and also what data constructors are exported for that type. Also TransitiveDctorExportError doesn't print data constructors currently, for some other complicated reasons (data constructors for the types in here are error sometimes).
garyb
force-pushed
the
dctor-operator-aliases
branch
from
fdf3af2 to
a816913
Compare
|
Ok, so there was a mistake in that last commit that was causing a failure despite what I said 😉 The test suite is still failing locally for me, but I have no idea why, as I can't interpret the output anymore. Having scanned through it I see nothing appears to be failing in the psc tests, but it still comes out with |
|
Oh, it fails in |
|
That might be my fault. Some of the tests print to stderr, and some print to stdout, so the actual error might be a few lines back (I am hoping to fix this soon). Otherwise, I can a look at this tomorrow if you'd like. |
|
I was about to ask if you had any ideas actually, as the tests started failing once |
|
Ok, well it seems Travis is happy now even though it isn't locally. Weird! |
|
|
||
| import qualified Language.PureScript.Constants as C | ||
|
|
||
| type AliasName = Either (Qualified Ident) (Qualified (ProperName 'ConstructorName)) |
There was a problem hiding this comment.
Could you please add some short comments here?
|
👍 Looks great to me! |
garyb
force-pushed
the
dctor-operator-aliases
branch
from
a816913 to
ee2e7ce
Compare
garyb
force-pushed
the
dctor-operator-aliases
branch
from
ee2e7ce to
9a377c4
Compare
|
Rebased & I added some comments for |
Operator aliases for data constructors
3 participants
Still needs work 😉