Skip to content

Field puns, fix #921#1603

Merged
paf31 merged 1 commit intomasterfrom
fieldpuns
Nov 3, 2015
Merged

Field puns, fix #921#1603
paf31 merged 1 commit intomasterfrom
fieldpuns

Conversation

@paf31
Copy link
Copy Markdown
Contributor

@paf31 paf31 commented Nov 3, 2015

This wasn't in 0.8 but was simple and seemed pretty useful.

@garyb
Copy link
Copy Markdown
Member

garyb commented Nov 3, 2015

Yeeuh! I'd been thinking about getting this in a lot lately too.

Does it/are we going to make it work for construction too? Like:

main = greet { greeting, name } 
  where
  greeting = "Hello"
  name = "World"

@paf31
Copy link
Copy Markdown
Contributor Author

paf31 commented Nov 3, 2015

Yep, we can. I wanted to put this PR in to get some comments first.

Actually, I was a bit eager here and just realized that @balajirrao had expressed interest in working on this. Apologies for that, but we could split construction into a separate PR if you're still interested in working on this? No pressure obviously.

@balajirrao
Copy link
Copy Markdown
Contributor

@paf31, yes, I want to work on this. It'll be a great way to start hacking purescript again. I'll send a PR very soon. Thanks!

@paf31
Copy link
Copy Markdown
Contributor Author

paf31 commented Nov 3, 2015

@balajirrao Sounds great! I'll merge this into master then, and you can make your PR there.

paf31 added a commit that referenced this pull request Nov 3, 2015
@paf31 paf31 merged commit 3c357d9 into master Nov 3, 2015
@paf31 paf31 deleted the fieldpuns branch November 3, 2015 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants