Skip to content

Fixes running tests on Windows#1402

Merged
garyb merged 2 commits intomasterfrom
1401-windows-tests
Aug 24, 2015
Merged

Fixes running tests on Windows#1402
garyb merged 2 commits intomasterfrom
1401-windows-tests

Conversation

@garyb
Copy link
Copy Markdown
Member

@garyb garyb commented Aug 18, 2015

Fixes #1401... but maybe should wait for #1382 first?

@paf31
Copy link
Copy Markdown
Contributor

paf31 commented Aug 18, 2015

👍

@phadej
Copy link
Copy Markdown
Contributor

phadej commented Aug 18, 2015

The tests/support/setup-win.cmd needs to be in extra-source-files (the travis build won't catch windows problems :( ).

@garyb
Copy link
Copy Markdown
Member Author

garyb commented Aug 18, 2015

Good call!

@paf31
Copy link
Copy Markdown
Contributor

paf31 commented Aug 23, 2015

@garyb Do you want to merge this before 0.7.4?

@garyb
Copy link
Copy Markdown
Member Author

garyb commented Aug 23, 2015

I'll probably update this before my next PR so I can actually test it, so yeah I guess so!

@garyb garyb force-pushed the 1401-windows-tests branch from 05226bf to d6ce2c5 Compare August 24, 2015 15:39
@garyb
Copy link
Copy Markdown
Member Author

garyb commented Aug 24, 2015

This should be good now, I'll merge once travis completes.

garyb added a commit that referenced this pull request Aug 24, 2015
@garyb garyb merged commit b2a8cf2 into master Aug 24, 2015
@paf31
Copy link
Copy Markdown
Contributor

paf31 commented Aug 24, 2015

👍

@garyb garyb deleted the 1401-windows-tests branch August 24, 2015 16:09
@rhendric rhendric mentioned this pull request Apr 21, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants