Skip to content

Fix #1246#1358

Merged
paf31 merged 2 commits intomasterfrom
1246
Aug 12, 2015
Merged

Fix #1246#1358
paf31 merged 2 commits intomasterfrom
1246

Conversation

@paf31
Copy link
Copy Markdown
Contributor

@paf31 paf31 commented Aug 11, 2015

@paf31
Copy link
Copy Markdown
Contributor Author

paf31 commented Aug 11, 2015

The issue seems to be that the content of the foreign module is captured inside the MakeActions structure.

@garyb
Copy link
Copy Markdown
Member

garyb commented Aug 11, 2015

Oops! It's much simpler now too, not sure why I didn't do it this way in the first place. 👍

@garyb
Copy link
Copy Markdown
Member

garyb commented Aug 11, 2015

Huh, looks like the core library stuff is working now, it's one of the stackage builds that is failing.

@paf31
Copy link
Copy Markdown
Contributor Author

paf31 commented Aug 11, 2015

@phadej Do you have any idea why this might happen? Maybe a build cache issue?

@paf31
Copy link
Copy Markdown
Contributor Author

paf31 commented Aug 11, 2015

Looks like the sandbox is being cached between different builds, perhaps? Maybe we have to revert to no caching.

@hdgarrood
Copy link
Copy Markdown
Contributor

Yeah, I think this is because of the sandbox being cached between builds (which was intended). However, oddly, it's the Stackage LTS 2.22 build that's failing; surely, if the Stackage snapshot version is fixed, none of the dependencies' versions should change? I think we should start by clearing the Travis cache and rerunning the build. I think this can be done inside Travis' web UI.

Perhaps it also makes sense to add --force-reinstalls to the cabal install command?

@paf31
Copy link
Copy Markdown
Contributor Author

paf31 commented Aug 11, 2015

My guess is that it's using the same cache between all of the different builds?

paf31 added a commit that referenced this pull request Aug 12, 2015
@paf31 paf31 merged commit d87bf07 into master Aug 12, 2015
@paf31 paf31 deleted the 1246 branch August 12, 2015 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants