Check the right kind of error is thrown in tests#1323
Check the right kind of error is thrown in tests#1323paf31 merged 7 commits intopurescript:masterfrom hdgarrood:should-fail-with
Conversation
Add a basic mechanism for declaring what kind of errors a test should throw, and add a few of these declarations to failing examples.
|
Looks fantastic, thank you! Once we have all tests marked up, perhaps it makes sense to use the lack of an annotation to mean "should pass"? |
|
@hdgarrood Can you show some examples of multiple errors or compilation errors? |
I'm not sure, we do already have a way of indicating this based on what directory the file is in; that is,
I've put 3 examples in already, I'm going to start going through and adding more now. Come to think of it I'm not sure if there are any that should produce more than 1 error, we'll see in a moment. |
This test is already provided via examples/failing/OverlappingInstances.purs
There was a problem hiding this comment.
@michaelficarra Here's an example with a test raising multiple errors.
|
Quite a few of these no longer testing what they are supposed to test since 0.7! I think this is all good now, though. |
|
Also, some next steps from here:
|
Check the right kind of error is thrown in tests
|
Brilliant! I've wanted this for so long and never got round to implementing it. Thanks! |
Add a basic mechanism for declaring what kind of errors a test should
throw, and add a few of these declarations to failing examples.
If you think this looks good I'll go ahead and add these declarations to all of the failing examples.
Refs (possibly fixes?) #1181