Skip to content

psc-publish: Try "bower.cmd" if "bower" is not found#1320

Merged
garyb merged 2 commits intopurescript:masterfrom
hdgarrood:psc-publish-dotcmd
Aug 3, 2015
Merged

psc-publish: Try "bower.cmd" if "bower" is not found#1320
garyb merged 2 commits intopurescript:masterfrom
hdgarrood:psc-publish-dotcmd

Conversation

@hdgarrood
Copy link
Copy Markdown
Contributor

Fixes #1317. I haven't tested this, though, as I don't have a Windows machine to hand.

@paf31
Copy link
Copy Markdown
Contributor

paf31 commented Aug 1, 2015

👍 Looks good. @garyb if I merge this, do you think you'd be able to test it, please?

@michaelficarra
Copy link
Copy Markdown
Contributor

I'd rather look for bower.cmd only if I'm on windows platform. If I have an executable bower.cmd in my path, I'd be surprised if it was executed.

@garyb
Copy link
Copy Markdown
Member

garyb commented Aug 1, 2015

Sure, I can test it now actually.

@garyb
Copy link
Copy Markdown
Member

garyb commented Aug 1, 2015

Well it didn't fail because bower was missing, but I just uploaded this: http://pursuit.purescript.org/packages/purescript-maybe/0.3.3 (no modules listed).

I think @michaelficarra has a point too, adding a platform check should be easy enough I think?

@hdgarrood
Copy link
Copy Markdown
Contributor Author

Yeah, the platform check is just System.Info.os == "mingw32" I think.

So you tried running psc-publish using this branch on Windows, with Bower installed, but when you uploaded it, there were no modules?

@hdgarrood
Copy link
Copy Markdown
Contributor Author

Also, @garyb, would you mind running it again but posting the output as a gist or something?

@garyb
Copy link
Copy Markdown
Member

garyb commented Aug 1, 2015

Sure thing:

{"uploader":null,"packageMeta":{"homepage":"https://github.com/purescript/purescript-maybe","repository":{"url":"git://github.com/purescript/purescript-maybe.git","type":"git"},"ignore":["**/.*","bower_components","node_modules","output","test","bower.json","gulpfile.js","package.json"],"dependencies":{"purescript-monoid":"^0.3.0"},"name":"purescript-maybe","keywords":["purescript"],"description":"Optional values"},"modules":[],"resolvedDependencies":{"purescript-control":"0.3.0","purescript-invariant":"0.3.0","purescript-monoid":"0.3.0","purescript-prelude":"0.1.1"},"bookmarks":[],"version":"0.3.3","github":["purescript","purescript-maybe"],"versionTag":"v0.3.3","compilerVersion":"0.7.1.0"}

@paf31
Copy link
Copy Markdown
Contributor

paf31 commented Aug 3, 2015

Is this good to merge now?

@hdgarrood
Copy link
Copy Markdown
Contributor Author

No, I still need to check the platform before trying bower.cmd.

@paf31
Copy link
Copy Markdown
Contributor

paf31 commented Aug 3, 2015

No worries, just checking. Thanks.

@hdgarrood
Copy link
Copy Markdown
Contributor Author

Ok I think this is good to go now. @garyb, would you mind testing this on Windows please?

@garyb
Copy link
Copy Markdown
Member

garyb commented Aug 3, 2015

👍

garyb added a commit that referenced this pull request Aug 3, 2015
psc-publish: Try "bower.cmd" if "bower" is not found
@garyb garyb merged commit 67e388e into purescript:master Aug 3, 2015
@hdgarrood hdgarrood deleted the psc-publish-dotcmd branch December 29, 2015 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants