Update test suite to use real supporting libraries#1316
Update test suite to use real supporting libraries#1316paf31 merged 8 commits intopurescript:masterfrom hdgarrood:update-test-support
Conversation
* Use real versions of supporting libraries * Use bower to make it easy to update supporting libraries
|
The bower.json for the set of supporting libraries is currently pointing to a specific commit in my fork for purescript-assert. Once purescript/purescript-assert#1 is merged we can point at the normal version. |
Descend into type class declarations when searching for declarations to use for completion, so that type class member functions appear in the results.
|
The CI failure on the "fix psci tests" commit turns out to be a real bug, which was that type class members didn't get completed in psci. I've just fixed this. |
|
Looks good but did you mean to check in the |
|
I did, I was thinking it would be nice to be able to run the tests without needing bower. I don't feel very strongly either way though. Would you rather the tests shelled out to bower at the beginning to get this code? |
|
Hmm, I'm not sure. It'd be nice to be able to accept PRs from Haskellers who don't have Bower, I suppose. I'm not sure it's so much more convenient that it's worth all the duplication of code though TBH. |
|
I don't think PRs are a problem if we don't check it in - if the submitter hasn't set their environment up, it won't matter, because we'll hear from Travis soon after they create the PR. I'll change that, then. |
|
Does it make sense to pull from master for these repos? I'm thinking if one makes a Prelude change, and it needs to be tested before a release. |
|
What sort of change are you thinking of? I think the test suites for individual libraries are better equipped to test changes in those libraries, and the tests here should really just be for the compiler. |
|
I was thinking about the bug wrt to inlining boolean operators. Changes were made to the published Prelude that affected the compiler's optimizations. If we change something like that again, would we want to coordinate and do compiler/library releases at the same time? |
Update test suite to use real supporting libraries
|
👍 Thanks very much! |
|
Something isn't quite right with the tests now, but I'm not sure if it's related to this. Several tests break on my machine, but |
|
Perhaps because not all of the instances have been updated? The old Prelude was taken from before all of the operator members had been changed, so for example |
|
The code compiles fine with |
|
Also, why would |
|
Ah, had to delete |
3 participants
The reason I did this is that I noticed that some of the tests had started producing warnings, because of type classes with operator members, and I think this might have been interfering with their results. (Investigating now).