Skip to content

Resolves #1235. Data declared in PSCI session can be queried for kind.#1311

Merged
paf31 merged 1 commit intopurescript:masterfrom
mjgpy3:1235_kind_query_fix
Jul 28, 2015
Merged

Resolves #1235. Data declared in PSCI session can be queried for kind.#1311
paf31 merged 1 commit intopurescript:masterfrom
mjgpy3:1235_kind_query_fix

Conversation

@mjgpy3
Copy link
Copy Markdown
Contributor

@mjgpy3 mjgpy3 commented Jul 28, 2015

Pretty easy fix. Local data definitions (psciLetBindings) were not being passed along to the kind query, so the type synonym IT was not successfully being defined.

Thoughts?

@mjgpy3
Copy link
Copy Markdown
Contributor Author

mjgpy3 commented Jul 28, 2015

Here's @hdgarrood's example:

> data Test = Test
Writing .psci_modules/node_modules/$PSCI/index.js
Writing .psci_modules/node_modules/$PSCI/externs.purs
> :k Test
Writing .psci_modules/node_modules/$PSCI/index.js
Writing .psci_modules/node_modules/$PSCI/externs.purs
*

Here's Maybe:

> data Maybe a = Nothing | Just
Writing .psci_modules/node_modules/$PSCI/index.js
Writing .psci_modules/node_modules/$PSCI/externs.purs
> :k Maybe
Writing .psci_modules/node_modules/$PSCI/index.js
Writing .psci_modules/node_modules/$PSCI/externs.purs
* -> *

@hdgarrood
Copy link
Copy Markdown
Contributor

hdgarrood commented Jul 28, 2015

Nice!

@paf31
Copy link
Copy Markdown
Contributor

paf31 commented Jul 28, 2015

👍 Cool, thanks!

@mjgpy3
Copy link
Copy Markdown
Contributor Author

mjgpy3 commented Jul 28, 2015

@paf31 good to go?

@paf31
Copy link
Copy Markdown
Contributor

paf31 commented Jul 28, 2015

I think so. I'm going to review and merge a bunch of stuff later today hopefully.

@mjgpy3
Copy link
Copy Markdown
Contributor Author

mjgpy3 commented Jul 28, 2015

Cool, thanks!

paf31 added a commit that referenced this pull request Jul 28, 2015
@paf31
Merge pull request #1311 from mjgpy3/1235_kind_query_fix
0644a4c 
Resolves #1235. Data declared in PSCI session can be queried for kind.
@paf31 paf31 merged commit 0644a4c into purescript:master Jul 28, 2015
@paf31
Copy link
Copy Markdown
Contributor

paf31 commented Jul 28, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mjgpy3 @hdgarrood @paf31