Add --dry-run option to psc-publish#1308
Merged
paf31 merged 1 commit intopurescript:masterfrom Jul 27, 2015
hdgarrood:publish-dry-run
Merged
Add --dry-run option to psc-publish#1308paf31 merged 1 commit intopurescript:masterfrom hdgarrood:publish-dry-run
paf31 merged 1 commit intopurescript:masterfrom
hdgarrood:publish-dry-run
Conversation
Contributor
There was a problem hiding this comment.
This all looks good, but do you think it's worth introducing an Options type now, so that we don't have to break the API again later?
Contributor
Author
There was a problem hiding this comment.
Yeah - I did introduce PublishOptions: https://github.com/purescript/purescript/pull/1308/files#diff-072e63067f4580fc7a99055d7d5655d0R55
I don't really consider this function part of the API, I think the real API is in Language.PureScript.Publish. If we do want to expand the command line API later, then this function's type will have to change, but considering that this module can't be imported anywhere*, I don't think that will be a problem.
*at least, I am pretty sure that this is the case.
paf31
added a commit
that referenced
this pull request
Jul 27, 2015
Add --dry-run option to psc-publish
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.