Improved error reporting in psc-bundle#1307
Merged
paf31 merged 4 commits intopurescript:masterfrom Jul 26, 2015
hdgarrood:bundle-error-reporting
Merged
Improved error reporting in psc-bundle#1307paf31 merged 4 commits intopurescript:masterfrom hdgarrood:bundle-error-reporting
paf31 merged 4 commits intopurescript:masterfrom
hdgarrood:bundle-error-reporting
Conversation
If language-javascript cannot parse a javascript file as part of psc-bundle, the error message is now included in the error that psc-bundle emits.
paf31
added a commit
that referenced
this pull request
Jul 26, 2015
Improved error reporting in psc-bundle
Contributor
|
👍 Thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is along the same lines as #1207 but it uses
ErrorInFile, although I renamed toErrorInModule, as we don't have the file information readily to hand. I also included the error from language-javascript (which is just aString) if the parsing fails. Here's an example output (the error arises from non-ascii characters in string literals, #1265):(by the way, that
--includeoption for pulp doesn't exist yet, I'm developing it at the moment)At the moment, it prints the
ModuleType(RegularorForeign) using theShowinstance. Perhaps there's a better way of displaying this information?