Only make composition suggestion on object . app function#1284
Merged
paf31 merged 1 commit intopurescript:masterfrom Jul 18, 2015
Merged
Only make composition suggestion on object . app function#1284paf31 merged 1 commit intopurescript:masterfrom
object . app function#1284paf31 merged 1 commit intopurescript:masterfrom
Conversation
mjgpy3
force-pushed
the
1272_reduce_false_positives_comp_sugg
branch
from
940b63a to
9c61180
Compare
Contributor
Author
|
(removed a debug trace) |
Contributor
Author
|
Here are the outputs SuggestComposition.purs: DoNotSuggestComposition.purs: DoNotSuggestComposition2.purs: |
Contributor
There was a problem hiding this comment.
We need to test the other way round too, don't we?
Contributor
Author
There was a problem hiding this comment.
Honestly, I'm not really sure. Can you give me a code example of what that might look like?
Contributor
Author
There was a problem hiding this comment.
As in, a PureScript example of code that might indicate a misuse of .
Contributor
|
Thanks for working on this! |
paf31
added a commit
that referenced
this pull request
Jul 18, 2015
…_sugg Only make composition suggestion on `object . app function`
Contributor
Author
|
@paf31 thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems to fix the cases given by @hdgarrood in #1272. I'm not sure it's totally done, but is more restrictive, I'd like to throw more cases at it if someone can come up some that are interesting.