Skip to content

Stackage#1263

Closed
phadej wants to merge 4 commits intopurescript:masterfrom
phadej:stackage
Closed

Stackage#1263
phadej wants to merge 4 commits intopurescript:masterfrom
phadej:stackage

Conversation

@phadej
Copy link
Copy Markdown
Contributor

@phadej phadej commented Jul 14, 2015

Update travis scripts. Update to use container infrastructure. Builds seems to start faster, but also to take longer (maybe it's the time of the day though).

This is motivated by #684 issue. I don't see any problems of adding purescript to stackage.

@mjgpy3
Copy link
Copy Markdown
Contributor

mjgpy3 commented Jul 14, 2015

👍

@phadej phadej force-pushed the stackage branch 2 times, most recently from 4cfd2b9 to fac22d5 Compare July 14, 2015 21:59
And download it before we install dependencies!
@hdgarrood
Copy link
Copy Markdown
Contributor

I'm just trying to understand what's going on here - I thought all that was necessary for getting on Stackage was putting your package name into their build-constraints.yaml file, and then they contact you if there are any problems? What is accomplished by checking that it builds with Stackage in the CI build here?

@phadej
Copy link
Copy Markdown
Contributor Author

phadej commented Jul 18, 2015

@hdgarrood This refactors travis builds a bit, e.g. verify that purescript can be built against newest lts and nightly stackage snapshots. Maybe those aren't truly necessary, but with them we can be more sure when accepting other pull requests. For example nightly has upper version constraints (so not using the latest version on some package, even when for purescript alone build plan could use them).

@hdgarrood
Copy link
Copy Markdown
Contributor

Ah, right, yeah that makes sense. Thanks for explaining.

@paf31
Copy link
Copy Markdown
Contributor

paf31 commented Aug 8, 2015

Is there anything left to do on this, now that #1270 is merged?

@hdgarrood
Copy link
Copy Markdown
Contributor

We could still add a couple more entries into our env matrix in order to verify purescript can be built with Stackage's lts and nightly snapshots; we don't do that currently.

Also, as Stackage is built with 7.8.4, perhaps it makes sense to switch 7.8.3 -> 7.8.4 for at least the Stackage builds, maybe also the other 7.8 builds as well? I can't see any particular reason to stick with 7.8.3.

@phadej
Copy link
Copy Markdown
Contributor Author

phadej commented Aug 9, 2015

I'll make a new PR

@phadej phadej closed this Aug 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants