Add psc-publish warning for unacceptable versions#1172
Merged
paf31 merged 1 commit intopurescript:masterfrom Jun 28, 2015
hdgarrood:warn-unacceptable-version
Merged
Add psc-publish warning for unacceptable versions#1172paf31 merged 1 commit intopurescript:masterfrom hdgarrood:warn-unacceptable-version
paf31 merged 1 commit intopurescript:masterfrom
hdgarrood:warn-unacceptable-version
Conversation
A problem arose with a package that depended on purescript-maybe, and was using the version 0.3.0-rc.1. Haskell's Data.Version refuses to parse this as a Version, which means purescript-maybe was missing from the resolvedDependencies. Now, if the resolved Bower version for dependencies is not parseable into a Version, a warning will be emitted, although it will still be missing from resolvedDependencies. In the longer term, we should look at using a Version data type that supports semver properly, which would probably eliminate this issue completely.
Contributor
There was a problem hiding this comment.
Why not just [PackageWarning] out of curiosity?
Contributor
Author
There was a problem hiding this comment.
I wanted to collect all the warnings of each type up together, so that I can then create one Box for each type of warning, in order to make the messages easier to understand. This code makes sure that, for example, all of the UndeclaredDependency warnings are collected up and displayed together, giving a message like "the following are installed but not declared: [list]". It works similarly for the other two PackageWarning constructors.
paf31
added a commit
that referenced
this pull request
Jun 28, 2015
Add psc-publish warning for unacceptable versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A problem arose with a package that depended on purescript-maybe, and
was using the version 0.3.0-rc.1. Haskell's Data.Version refuses to
parse this as a Version, which means purescript-maybe was missing from
the resolvedDependencies.
Now, if the resolved Bower version for dependencies is not parseable
into a Version, a warning will be emitted, although it will still be
missing from resolvedDependencies.
In the longer term, we should look at using a Version data type that
supports semver properly, which would probably eliminate this issue
completely.