Skip to content

Remove poor performing entails.filterModule#1161

Merged
paf31 merged 1 commit intopurescript:masterfrom
puffnfresh:perf/entails-filtermodule
Jun 11, 2015
Merged

Remove poor performing entails.filterModule#1161
paf31 merged 1 commit intopurescript:masterfrom
puffnfresh:perf/entails-filtermodule

Conversation

@puffnfresh
Copy link
Copy Markdown
Contributor

Turns out this was the last thing using the getTypeClassDictionaries
list, but was also filtering down to the module. Changed to using the
underlying Map, which provides quick indexing of the module.

Some more numbers:

benchmarking unpatched
time                 59.75 s    (51.44 s .. 67.70 s)
                     0.998 R²   (NaN R² .. 1.000 R²)
mean                 59.01 s    (57.54 s .. 60.14 s)
std dev              1.737 s    (0.0 s .. 1.954 s)
variance introduced by outliers: 19% (moderately inflated)

benchmarking patched
time                 32.53 s    (25.64 s .. 39.85 s)
                     0.994 R²   (0.977 R² .. 1.000 R²)
mean                 33.09 s    (31.42 s .. 34.06 s)
std dev              1.496 s    (0.0 s .. 1.670 s)
variance introduced by outliers: 19% (moderately inflated)

I have no idea why Criterion gives a NaN...

Turns out this was the last thing using the getTypeClassDictionaries
list, but was also filtering down to the module. Changed to using the
underlying Map, which provides quick indexing of the module.

Some more numbers:

    benchmarking unpatched
    time                 59.75 s    (51.44 s .. 67.70 s)
                         0.998 R²   (NaN R² .. 1.000 R²)
    mean                 59.01 s    (57.54 s .. 60.14 s)
    std dev              1.737 s    (0.0 s .. 1.954 s)
    variance introduced by outliers: 19% (moderately inflated)

    benchmarking patched
    time                 32.53 s    (25.64 s .. 39.85 s)
                         0.994 R²   (0.977 R² .. 1.000 R²)
    mean                 33.09 s    (31.42 s .. 34.06 s)
    std dev              1.496 s    (0.0 s .. 1.670 s)
    variance introduced by outliers: 19% (moderately inflated)

I have no idea why Criterion gives a NaN...
@garyb
Copy link
Copy Markdown
Member

garyb commented Jun 11, 2015

😍

@paf31
Copy link
Copy Markdown
Contributor

paf31 commented Jun 11, 2015

👍

@jdegoes
Copy link
Copy Markdown

jdegoes commented Jun 11, 2015

Only doubling performance? You're slipping, dude! 😉

💯 🎆 😂

paf31 added a commit that referenced this pull request Jun 11, 2015
Remove poor performing entails.filterModule
@paf31 paf31 merged commit 2021aa0 into purescript:master Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants