Skip to content

Resolves #1097. "Reading ..." error output is only shown when passed …#1114

Merged
paf31 merged 1 commit intopurescript:masterfrom
mjgpy3:1097_less_verbose_compile_errors
May 17, 2015
Merged

Resolves #1097. "Reading ..." error output is only shown when passed …#1114
paf31 merged 1 commit intopurescript:masterfrom
mjgpy3:1097_less_verbose_compile_errors

Conversation

@mjgpy3
Copy link
Copy Markdown
Contributor

@mjgpy3 mjgpy3 commented May 12, 2015

…flag.

Uses the --verbose-errors flag to hide some "Reading ..." errors. See #1097.

Thank you @paf31 and @hdgarrood for the help. This should resolve the errors when the flag is given. Here are two example commands:

With Flag

~/.cabal/bin/psc-make --verbose-errors ~/tmp/bower_components/purescript-prelude/src/Prelude.purs ConflictingImport.purs
Reading output/Prelude/externs.purs
Error:
Error in module ConflictingImport:
Cannot declare id since another declaration of that name was imported from Prelude
Possible fix: hide id when importing Prelude:
import Prelude hiding (id)
See https://github.com/purescript/purescript/wiki/Error-Code-ConflictingImport for more information, or to contribute content related to this error.

Without flag

~/.cabal/bin/psc-make ~/tmp/bower_components/purescript-prelude/src/Prelude.purs ConflictingImport.purs
Error:
Error in module ConflictingImport:
Cannot declare id since another declaration of that name was imported from Prelude
Possible fix: hide id when importing Prelude:
import Prelude hiding (id)
See https://github.com/purescript/purescript/wiki/Error-Code-ConflictingImport for more information, or to contribute content related to this error.

…en passed flag.

Uses the --verbose-errors flag to hide some "Reading ..." errors.
@mjgpy3
Copy link
Copy Markdown
Contributor Author

mjgpy3 commented May 17, 2015

@paf31 does this seem correct? (Sorry, I'm not sure if "bumps" are proper open-source etiquette 😕 )

paf31 added a commit that referenced this pull request May 17, 2015
Resolves #1097. "Reading ..." error output is only shown when passed …
@paf31 paf31 merged commit 76940aa into purescript:master May 17, 2015
@paf31
Copy link
Copy Markdown
Contributor

paf31 commented May 17, 2015

👍 Sorry, yes, and thanks. Please do remind me if this happens again, I just missed this one accidentally.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants