Skip to content

Remove array type notation and cons binders#1083

Merged
paf31 merged 2 commits intomasterfrom
arrays
Apr 29, 2015
Merged

Remove array type notation and cons binders#1083
paf31 merged 2 commits intomasterfrom
arrays

Conversation

@paf31
Copy link
Copy Markdown
Contributor

@paf31 paf31 commented Apr 26, 2015

@garyb Could you please review this one? It's mostly deletions and modified tests, but you might like to look at the way the new errors work. I just hacked them in using error for now, since they will be temporary.

@garyb
Copy link
Copy Markdown
Member

garyb commented Apr 26, 2015

The errors are a bit icky, but I guess this is as good a way as any to do it. It would be nice to include position info though.

This is actually going to make CoreImp easier too, as one of the problems there was to abstract the array behaviours of cons patterns.

@paf31
Copy link
Copy Markdown
Contributor Author

paf31 commented Apr 26, 2015

Yeah, error is ugly, but using fail won't work since Parsec will just try the next alternative. I'll see if I can add position info.

paf31 added a commit that referenced this pull request Apr 29, 2015
Remove array type notation and cons binders
@paf31 paf31 merged commit 498dadc into master Apr 29, 2015
@paf31 paf31 deleted the arrays branch April 29, 2015 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants