Relax lower bound of transformers to 0.3.0.0#1048
Merged
paf31 merged 1 commit intopurescript:masterfrom Apr 15, 2015
hdgarrood:transformers-compat
Merged
Relax lower bound of transformers to 0.3.0.0#1048paf31 merged 1 commit intopurescript:masterfrom hdgarrood:transformers-compat
paf31 merged 1 commit intopurescript:masterfrom
hdgarrood:transformers-compat
Conversation
Replace all use of Control.Monad.Except with one or more of: * Control.Monad * Control.Monad.Error.Class * Control.Monad.Trans.Except Also add transformers-compat to purescript.cabal
Contributor
Author
|
Sorry, it looks like I wasn't quite right; by default, |
Contributor
Author
|
On further investigation it seems that |
Contributor
|
No, I think this is good. I'll merge. Thanks! |
paf31
added a commit
that referenced
this pull request
Apr 15, 2015
Relax lower bound of transformers to 0.3.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits do 3 things:
Control.Monad.Exceptwith one or more ofControl.Monad,Control.Monad.Error.Class (MonadError(..)), andControl.Monad.Trans.Except, sinceControl.Monad.Exceptseems to just re-export all of these. This is necessary in the case where we are usingtransformers==0.3.*, becausetransformers-compatdoesn't haveControl.Monad.Except(not sure why). I think this is worth doing anyway; I don't like howControl.Monad.Exceptre-exports so much stuff.transformers-compat. purescript was previously bringing it in as a transitive dependency, so the only effect that this should have is allowing the importing of its modules where necessary.transformerslower bound to 0.3.*; now that we havetransformers-compat, purescript can compile withtransformers==0.3.*. I tested this by doing:The effect of this is that you can now easily install
yesod-bintogether withpurescriptin a sandbox. Also, it is still possible to gettransformers==0.4.*when resolving constraints - these changes appear to have no effect on the versions selected in those cases which currently can be resolved.