Make exportedDeclarations filter everything#1045
Closed
hdgarrood wants to merge 5 commits intopurescript:masterfrom
hdgarrood:issue-747
Closed
Make exportedDeclarations filter everything#1045hdgarrood wants to merge 5 commits intopurescript:masterfrom hdgarrood:issue-747
exportedDeclarations filter everything#1045hdgarrood wants to merge 5 commits intopurescript:masterfrom
hdgarrood:issue-747
Conversation
Fixes #747 In addition to its previous behaviour of filtering out declarations which are not exported, `exportedDeclarations` will also: * Filter out instance declarations which refer to non-exported types, as these can be considered as unexported. * Descend into data declarations, and filter out unexported constructors The effect of this is that tooling like psci and psc-docs can now simply call `exportedDeclarations` and not have to worry about anything.
Contributor
Author
|
I've just come up with another approach which I like better:
|
Contributor
Author
|
Actually, I'm going to close this and resubmit to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #747
I've added a test case to
examples/manual/passingfor testing theexportedDeclarationsfunction.Also, the new functions in Language.PureScript.AST.Declarations don't necessarily need to be exported; I put them at the top level so that there's fewer bound variables to worry about, and so that they can be tested in ghci. I would be happy to move them into a separate module to avoid them being exported if you think that's a good idea.