@garyb I'll leave this one to you to review, since you know the code the best. Maybe newtyping the String would be good though? Given this construct is likely going away in 0.8, it might not matter too much.

Coverage remained the same at 77.13% when pulling b151eef on andyarvanitis:core-imp into e1a4798 on purescript:core-imp.

Looks basically fine to me, I'd like to move a few things around perhaps to defer the mapping of extern type to CoreImp rather than CoreFn, but I'll merge this as it is and then have a play. Thanks!

Cool, thanks!

Ok, done my tweaks - I introduced a ForeignCode newtype even if it is just a temporary thing, and it maintains that type throughout the Core steps now, I just remap it to JS in the JS codgen. Does that still work for what you need? I figure that should still work as we can just insert another step in the compilation process if it needs some special handling before going into codegen.

I'm pretty sure that will be fine -- I'll make sure when I get back to my desk in a little while.

👍