fix: do not wait for all targets when connecting #14395
Merged
+36
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/do-no-wait
branch
9 times, most recently
from
1a37b17 to
77690bb
Compare
Lightning00Blade
approved these changes
Nov 5, 2025
OrKoN
force-pushed
the
orkon/do-no-wait
branch
2 times, most recently
from
0189ebd to
388dbe0
Compare
OrKoN
force-pushed
the
orkon/do-no-wait
branch
from
388dbe0 to
1211e04
Compare
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue of Puppeteer not being able to connect to some targets. Usually, it happens if the page or tab target is excluded by a filter but the browser instance has a child iframe target for excluded targets. In this case, the child target will never be auto-attached.
This PR fixes this by only expecting tab targets to have any child target attaching. This might mean that iframe subtargets are not fully initialized on connect but this should generally be fine.