feat: expose connection in CdpBrowserContext #14346
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
done and success now |
1 participant
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
No, this change only adds a simple getter method that exposes an existing private property.
If relevant, did you update the documentation?
No documentation update needed as this is an internal API addition.
Summary
This PR exposes the internal
Connectionobject inCdpBrowserContextby adding a public getter method. This allows external code to access the underlying CDP connection when working with browser contexts, which can be useful for advanced use cases that need direct access to the connection for sending custom CDP commands or managing sessions.The change adds a simple
get connection(): Connectionmethod that returns the private#connectionproperty, maintaining the existing encapsulation while providing controlled access to the connection object.Does this PR introduce a breaking change?
No, this is a purely additive change that doesn't modify any existing APIs or behavior.
Other information
This change only modifies
packages/puppeteer-core/src/cdp/BrowserContext.tsand adds 4 lines of code to expose the connection getter method.