Skip to content

Conversation

@ModProg
Copy link
Contributor

@ModProg ModProg commented Jan 24, 2025

fixes #1009

Feel free to close, I mainly looked into it for my self, but maybe this is useful for others as well.

@Martin1887
Copy link
Collaborator

Nice! The only thing is that fields and variants don't actually require enabling options, but they are always None or not emitted when the options are not enabled.

@ModProg
Copy link
Contributor Author

ModProg commented Jan 27, 2025

Nice! The only thing is that fields and variants don't actually require enabling options, but they are always None or not emitted when the options are not enabled.

Yes, but if you don't enable them, you don't need to handle them, that is what I meant by that. But I'm happy to adjust that wording if you have a better one!

@Martin1887
Copy link
Collaborator

I would say something like 'Only relevant if this flag is enabled, always None otherwise (or 'Only triggered if this flag is enabled').

@ModProg
Copy link
Contributor Author

ModProg commented Jan 30, 2025

Used the wording "Only parsed and emitted with ....`

@Martin1887
Copy link
Collaborator

Great!, the only thing is the comment for metadata blocks, it seems that you forgot to update it.

@ModProg ModProg requested a review from Martin1887 February 2, 2025 16:08
@Martin1887 Martin1887 merged commit 4564d43 into pulldown-cmark:master Feb 3, 2025
6 checks passed
Copy link
Collaborator

@Martin1887 Martin1887 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand documentation on Event e.g. link to reference

2 participants