Open
Conversation
ionrock
reviewed
Jun 7, 2018
| cacheable_methods=None): | ||
| if hasattr(response, 'chunked'): | ||
| pytest.skip('Requests is new enough, test makes no sense.') | ||
| # delattr(response, 'chunked') |
Contributor
There was a problem hiding this comment.
Can you remove this comment?
ionrock
reviewed
Jun 7, 2018
| def build_response(self, request, response, from_cache=False, | ||
| cacheable_methods=None): | ||
| if hasattr(response, 'chunked'): | ||
| pytest.skip('Requests is new enough, test makes no sense.') |
Contributor
There was a problem hiding this comment.
I might reword this as Requests version supports chucked. Skipping this test.
ionrock
reviewed
Jun 7, 2018
| cacheable_methods) | ||
| sess = Session() | ||
| sess.mount('http://', NoChunked()) | ||
| sess.get('http://httpbin.org/cache/60') |
Contributor
There was a problem hiding this comment.
You need to assert something here! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a simple fix for #137 and a test that will only run on old versions of requests. Sorry about the revert commits, I can squash locally and re-submit if it helps.