Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 87.47% 88.22% +0.75%
==========================================
Files 82 83 +1
Lines 9507 9688 +181
==========================================
+ Hits 8316 8547 +231
+ Misses 1191 1141 -50 ☔ View full report in Codecov by Sentry. |
Member
Author
|
@Zartris if you wanna review / try it out this shoulf be mega fasttttt |
Contributor
|
Oh that was quick! Ill take a look today |
Member
Author
|
pollock scenario use_vmas_env(
scenario_name="pollock",
render=False,
save_render=False,
random_action=True,
continuous_actions=False,
n_agents=15,
n_lines=15,
n_boxes=15,
lidar=True,
n_steps=100,
num_envs=32,
)before PR:
after PR:
🚀 |
Contributor
|
Everything seems to work good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuation of #122
What we vectorize
Let me recap the levels of looping:
And here is what we vectorize:
Benchmarking
pollock scenario
before PR:
M1 cpu: 134.55210709571838s
CUDA: 571.7651047706604s
after PR:
M1 cpu: 22.2061710357666s (0.16x the previous time)
CUDA: 91.27248549461365s (0.15 x the previous time)
benefit will increase in the number of steps and envs
🚀