[Feature] Adding pre and post step to BaseScenario#112
Merged
matteobettini merged 5 commits intoproroklab:mainfrom Jun 25, 2024
Merged
[Feature] Adding pre and post step to BaseScenario#112matteobettini merged 5 commits intoproroklab:mainfrom
matteobettini merged 5 commits intoproroklab:mainfrom
Conversation
Contributor
Author
|
Should maybe remove the returns however the flake8 was not happy about empty methods. |
Member
|
Looks good! Can we simplify the docstring of poststep? I don’t think we need to go into cat and unsqueeze, just appending to a list is fine |
Member
|
Also maybe an underscore in the name like |
Contributor
Author
|
Done |
Member
|
Fabulous, last addition I missed: can you add them to the BaseScenarion docstring under the optional methods? |
Contributor
Author
|
Like this? |
Member
|
Yeah just remove the added line |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #110