Skip to content

Commit 422d2e0

Browse files
committed
Fix bugs due to internal format parsing change
1 parent 018d15a commit 422d2e0

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

proplot/axes/base.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -706,8 +706,9 @@ def __init__(self, *args, **kwargs):
706706
kw_format = _pop_props(kwargs, 'patch') # background properties
707707
if 'zorder' in kw_format: # special case: refers to the entire axes
708708
kwargs['zorder'] = kw_format.pop('zorder')
709-
for cls in {Axes, type(self)}:
710-
kw_format.update(_pop_params(kwargs, self._format_signatures.get(cls)))
709+
for cls, sig in self._format_signatures.items():
710+
if isinstance(self, cls):
711+
kw_format.update(_pop_params(kwargs, sig))
711712
super().__init__(*args, **kwargs)
712713

713714
# Varous scalar properties

proplot/axes/cartesian.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1219,7 +1219,7 @@ def _parse_alt(self, x, **kwargs):
12191219
"""
12201220
Optionally omit the leading x or y from "twin axes" methods.
12211221
"""
1222-
sig = self._format_signatures[type(self)]
1222+
sig = self._format_signatures[CartesianAxes]
12231223
keys = tuple(key[1:] for key in sig.parameters if key[0] == x)
12241224
kwargs = {(x + key if key in keys else key): val for key, val in kwargs.items()}
12251225
for axis in 'xy': # standardize format() location aliases

proplot/ui.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,8 +185,8 @@ def subplots(*args, **kwargs):
185185
# Format keywords
186186
rc_kw, rc_mode = _pop_rc(kwargs)
187187
kwformat = _pop_params(kwargs, pfigure.Figure._format_signature)
188-
for name, signature in paxes.Axes._format_signatures.items():
189-
kwformat.update(_pop_params(kwargs, signature))
188+
for sig in paxes.Axes._format_signatures.values():
189+
kwformat.update(_pop_params(kwargs, sig))
190190
# Initialize
191191
fig = figure(rc_kw=rc_kw, **kwargs)
192192
axs = fig.add_subplots(*args, **kwsubs)

0 commit comments

Comments
 (0)