src/types/errors.ts (1)

1-8: Consider typing code with ErrorCategory for stronger guarantees.

If ErrorCategory represents standardized error codes, wire it into EvalErrorInfo.code (in src/types/result.ts) to prevent free-form strings. Keep this file as a thin re-export hub to avoid duplication.

src/types/result.ts (1)

5-11: Type EvalErrorInfo.code with ErrorCategory (instead of string).

Improves safety and keeps taxonomy consistent with src/types/errors.ts.

Apply:

+import type { ErrorCategory } from './errors';
 export interface EvalErrorInfo {
   type: ErrorType;
-  code?: string;
+  code?: ErrorCategory;
   message: string;
   hint?: string;
   provider?: string;

src/lib/errors.ts (1)

22-32: Include stack/cause in toInfo for parity with EvalErrorInfo.

Restores fidelity for CLI/JSON outputs and debugging.

Apply:

   toInfo(): EvalErrorInfo {
     return {
       type: this.type,
       code: this.code,
       message: this.message,
       hint: this.hint,
       provider: this.provider,
       requestId: this.requestId,
       raw: this.raw,
+      stack: this.stack,
+      // Avoid leaking objects; only surface string causes
+      cause: typeof this.cause === 'string' ? this.cause : undefined,
     };
   }

src/lib/guardrails (4)

42-49: Use unknown in catch and clear the timer immediately.

Avoid any; clear the timer before heavy work to prevent leaks.

Apply:

-    try {
+    try {
       const out = await call(args, controller.signal);
       clearTimeout(timeout);
       return out;
-    } catch (err: any) {
+    } catch (err: unknown) {
+      clearTimeout(timeout);
       attempt++;

---

51-61: Harden error extraction and retryability checks.

Broaden network error codes and parse status from common SDK shapes.

Apply:

-      const code = err?.code ?? err?.status ?? err?.name;
-      const status = err?.status as number | undefined;
-      const retryAfterHeader = err?.retryAfterSeconds;
-      const retryAfter = Number(retryAfterHeader);
+      const anyErr = err as Record<string, any> | undefined;
+      const code = anyErr?.code ?? anyErr?.name ?? anyErr?.status ?? anyErr?.cause?.code;
+      const status: number | undefined =
+        anyErr?.status ??
+        anyErr?.statusCode ??
+        anyErr?.response?.status ??
+        anyErr?.response?.statusCode;
+      // Retry-After: seconds or HTTP-date; look in common locations
+      const raHeader =
+        anyErr?.retryAfterSeconds ??
+        anyErr?.response?.headers?.['retry-after'] ??
+        anyErr?.headers?.['retry-after'];
+      const retryAfter =
+        typeof raHeader === 'string' && /^\d+$/.test(raHeader)
+          ? Number(raHeader)
+          : Number(raHeader); // best effort fallback

---

78-85: Respect Retry-After more robustly and avoid over-sleeping.

Use parsed retryAfter when present; otherwise exponential backoff with jitter.

Apply:

-      let delay = Math.min(max, base * 2 ** (attempt - 1));
-      if (respectRetryAfter && Number.isFinite(retryAfter) && retryAfter! > 0) {
-        delay = Math.max(delay, retryAfter! * 1000);
-      }
-      await sleep(jitter(delay));
-      clearTimeout(timeout);
+      let delay = Math.min(max, base * 2 ** (attempt - 1));
+      if (respectRetryAfter && Number.isFinite(retryAfter) && retryAfter > 0) {
+        delay = Math.max(delay, retryAfter * 1000);
+      }
+      await sleep(jitter(delay));

---

65-73: Sanitize raw error details before attaching.

Error messages can leak tokens/PII; consider redaction before adding to raw.

Example:

const msg = String((anyErr as any)?.message ?? '');
const safeMsg = msg.replace(/(sk-[A-Za-z0-9]{20,})/g, '[REDACTED]');
raw: { status, code, message: safeMsg }

As per coding guidelines.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro