alertmanager: support webhook_url_file option in discord_server recei… #8035
+363
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver config In v0.28.0, alertmanager added support for webhook_url_file option in discord_config. This PR adds the option to the alertmanagerconfigs-crd, along with the appropriate validation and documentation. Fixes prometheus-operator#7159
|
I made these changes before I knew about the existing effort in #6346. If I had known I would have worked to get the changes in that PR rebased instead of starting from scratch, but here we are. |
|
hi @teekennedy you can always add dongjiang1989 #6346, and we can try to work on reviewing |
|
@dongjiang1989 would you mind taking a look at this PR when you have a chance? Your input would be appreciated given your work on a similar PR. |
| APIURL *v1.SecretKeySelector `json:"apiURL,omitempty"` | ||
| // webhookURLFile defines the file to read the Discord webhook URL from. | ||
| // It is mutually exclusive with `apiURL`. | ||
| // Either `apiURL` or `webhookURLFile` is required. |
There was a problem hiding this comment.
Suggested change
| // Either `apiURL` or `webhookURLFile` is required. | |
| // Either `apiURL` or `webhookURLFile` is required. | |
| // It requires Alertmanager >= 0.28.0. |
|
@teekennedy Maybe some security problem |
|
It'd be lovely to get this in! We're currently templating the kube-prometheus with the webhook URL directly 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the webhook_url_file option in discord_server alertmanager configuration.
In v0.28.0, alertmanager added support for webhook_url_file option in discord_config. This PR adds the option to the alertmanagerconfigs CRD, along with the appropriate validation and documentation.
Fixes #7159
Type of change
CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
I've added unit tests for the new validation code paths, and verified that existing tests pass. I did not setup a dev environment to be able to run e2e tests, but I did test this new configuration option on my homelab k8s cluster and it's working there.
Changelog entry